-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize WebUI Gallery export #17395
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have templates with html and css files in a folder under config/darktable to give users a way to create their own galleries. |
let me know what you think about the new padding vertically |
i agree. i think maybe having a templating engine would be a bit too much for the html but i definitely see having the css file available to change so that people can make their own colors, have a different grid layout etc. unfortunately i dont know much about c so i can't volunteer for it. but it is a good idea |
@marceloexc : Is that PR still in your scope? Would be nice to fix the CSS issue. |
sorry about the long delay, ill get a working commit by this week |
Don't be sorry, all this is done on our free time! |
came back to this, i have the correct gap on my machine? when you do inspect element on the browser, do you see the element havingpadding-inline: 20px; padding-block: 40px; applied instead of just padding: 20px ?this online gallery works on the devices i tested - could this be a matter of browser cache? |
To me this example doesn't work. In your title "nov9_dt_web_test" you don't have letter having low jamb (don't know the right word, in French - Jambage bas) like g, y, p or q and those letters gets cut. Just try and you'll see. |
old webui gallery exporter did not work very well with mobile screens (everything appeared too small and not reactive)
kept the same hanatos style, but started using HTML standard elements (
<header>, <footer>, <figure>
, instead of everything being<div> <div> <div>
...)switched from xhtml to the html5 (no self closing tags for elements)