Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize WebUI Gallery export #17395

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marceloexc
Copy link

@marceloexc marceloexc commented Aug 30, 2024

old webui gallery exporter did not work very well with mobile screens (everything appeared too small and not reactive)

kept the same hanatos style, but started using HTML standard elements (<header>, <footer>, <figure>, instead of everything being <div> <div> <div>...)

switched from xhtml to the html5 (no self closing tags for elements)

@TurboGit TurboGit added this to the 5.0 milestone Aug 30, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are at it... Can we have a bit more space of the main title and the start of the gallery:

image

@TurboGit TurboGit added priority: low core features work as expected, only secondary/optional features don't scope: DAM managing files, collections, archiving, metadata, etc. documentation-pending a documentation work is required release notes: pending labels Aug 30, 2024
@zisoft
Copy link
Collaborator

zisoft commented Aug 30, 2024

Would be nice to have templates with html and css files in a folder under config/darktable to give users a way to create their own galleries.
Like with the watermarks.

@marceloexc
Copy link
Author

let me know what you think about the new padding vertically

@marceloexc
Copy link
Author

Would be nice to have templates with html and css files in a folder under config/darktable to give users a way to create their own galleries. Like with the watermarks.

i agree. i think maybe having a templating engine would be a bit too much for the html but i definitely see having the css file available to change so that people can make their own colors, have a different grid layout etc.

unfortunately i dont know much about c so i can't volunteer for it. but it is a good idea

@TurboGit
Copy link
Member

TurboGit commented Sep 1, 2024

I don't have more spacing for the gallery title:

image

@TurboGit
Copy link
Member

@marceloexc : Is that PR still in your scope? Would be nice to fix the CSS issue.

@marceloexc
Copy link
Author

sorry about the long delay, ill get a working commit by this week

@TurboGit
Copy link
Member

sorry about the long delay, ill get a working commit by this week

Don't be sorry, all this is done on our free time!

@marceloexc
Copy link
Author

came back to this, i have the correct gap on my machine? when you do inspect element on the browser, do you see the

element having padding-inline: 20px; padding-block: 40px; applied instead of just padding: 20px?

this online gallery works
on the devices i tested - could this be a matter of browser cache?

@TurboGit
Copy link
Member

this online gallery works on the devices i tested - could this be a matter of browser cache?

To me this example doesn't work. In your title "nov9_dt_web_test" you don't have letter having low jamb (don't know the right word, in French - Jambage bas) like g, y, p or q and those letters gets cut. Just try and you'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-pending a documentation work is required priority: low core features work as expected, only secondary/optional features don't release notes: pending scope: DAM managing files, collections, archiving, metadata, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants